[OpaqueValues] Emit RValue of AnyHashable erasure into new context. #67752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
nate-chandler
changed the title
nate-chandler
force-pushed
the
opaque-values/20230804/1/any-hashable-var
branch
from
30b6f79 to
c451fc2
Compare
When storing an instance of some type that conforms to Hashable into an lvalue of type AnyHashable, the source rvalue needs to be emitted within a new SGFContext. Otherwise, the LocalVarInitialization for the var of type AnyHashable would be used and an attempt would be made to store the instance of the conforming type into the projected box.
nate-chandler
force-pushed
the
opaque-values/20230804/1/any-hashable-var
branch
from
c451fc2 to
999f2b0
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When storing an instance of some type that conforms to Hashable into an lvalue of type AnyHashable, the source rvalue needs to be emitted within a new SGFContext. Otherwise, the LocalVarInitialization for the var of type AnyHashable would be used and an attempt would be made to store the instance of the conforming type into the projected box.